Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Update background.js - #11807

Merged
Hainish merged 3 commits into
masterfrom
unknown repository
Aug 11, 2017
Merged

Hainish merged 3 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Aug 10, 2017

Copy link
Copy Markdown

No description provided.

@ghost ghost mentioned this pull request Aug 10, 2017
Comment thread chromium/background.js Outdated
function setStorage(values) {
return new Promise(resolve => {
storage.set(values, resolve);
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add closing parenthesis here. Also, I'd rather have this in the import_settings function. Just call await to the promise. But consolidating the four separate calls is 👍.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hainish Thanks for pointing it out!

@Hainish

Hainish commented Aug 11, 2017

Copy link
Copy Markdown
Member

Great now

Also, I'd rather have this in the import_settings function. Just call await to the promise

@Hainish Hainish closed this Aug 11, 2017
@Hainish Hainish reopened this Aug 11, 2017
@ghost

ghost commented Aug 11, 2017

Copy link
Copy Markdown
Author

@Hainish Done.

@Hainish
Hainish merged commit 518a5be into EFForg:master Aug 11, 2017
@Hainish

Hainish commented Aug 11, 2017

Copy link
Copy Markdown
Member

Thanks!

@ghost
ghost deleted the patch-2 branch August 11, 2017 05:05
luciancor pushed a commit to luciancor/https-everywhere that referenced this pull request Aug 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant